Net income from 2018 federal tax return (Line 236) what do enter it from? t4? my husband has two T4 from two provinces how do i do that then?

You would simply add the amounts from both T4's together to estimate line 236.  As far as entering 2 T4 slips that are from different provinces, you would just enter them individually and indicate the province on the T4 entry.